Ufe 0.4.8: Add classifications and metadata to def #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ufe 0.4.8 has multiple changes to improve NodeDef discovery: NodeDef: - Expose read-only interface to query node classifications (allows sorting them in a node picker) - Expose read-only metadata API (limited to known USD metadata tags at the moment) - Remove internally kept data. Everything is built on-the-fly from the SdrShaderNode information - Expanded the port API to allow name discovery and single port queries AttributeDef: - The base class in Ufe is now a full interface. Added an implementation for USD that returns the information directly from the associated SdrShaderProperty - Expose read-only metadata API (limited to known USD tags at the moment)
ppt-adsk
requested changes
May 3, 2022
feldstj
requested changes
May 3, 2022
lib/mayaUsd/ufe/UsdShaderNodeDef.cpp
Outdated
|
|
||
| Ufe::AttributeDef::ConstPtr UsdShaderNodeDef::output(const std::string& name) const | ||
| { | ||
| if (fShaderNodeDef) { |
There was a problem hiding this comment.
Can these two if conditions be combined? Unless of course you follow Pierre's suggestion of removing the nullptr check.
ppt-adsk
approved these changes
May 5, 2022
feldstj
approved these changes
May 6, 2022
JGamache-autodesk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ufe 0.4.8 has multiple changes to improve NodeDef discovery:
NodeDef:
sorting them in a node picker)
the moment)
SdrShaderNode information
AttributeDef:
for USD that returns the information directly from the associated
SdrShaderProperty
moment)